search

confluentinc / cp-demo

Confluent Platform Demo including Apache Kafka, ksqlDB, Control Center, Schema Registry, Security, Schema Linking, and Cluster Linking
Apache License 2.0
38 stars 322 forks source link

Update docker compose file format #421

Closed chuck-confluent closed 2 years ago

chuck-confluent commented 2 years ago

Description

What behavior does this PR change, and why?

Update to use modern compose specification and incorporate health checks. This will lead hopefully to more predictable behavior and fewer transient errors since services will be guaranteed to be up when receiving requests.

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

gitpod-io[bot] commented 2 years ago

chuck-confluent commented 2 years ago

yet another docker compose v2.2.3 bug affecting this

However 1.29 works, and 2.4.1 works

chuck-confluent commented 2 years ago

pr merged with gitpod to update workspace docker compose version to 2.4.1. Not sure when they will go live. So prebuilds still might not work for a while, but the demo is in good shape for 1.29 and 2.4.1 folks, which should be most folks because those are the versions that ship with docker desktop.