confluentinc / cp-docker-images

[DEPRECATED] Docker images for Confluent Platform.
Apache License 2.0
1.14k stars 704 forks source link

Confluent Control Center does not propagate some environment variables #543

Closed angelbarrera92 closed 6 years ago

angelbarrera92 commented 6 years ago

Good night.

It seems that the confluent.controlcenter.kafka.<name>.bootstrap.servers property is not spreading correctly in the configuration file.

I've developed a couple of tests that prove the change I will propose. They are in the repository: https://github.com/angelbarrera92/confluent-docker-utils/tree/bugfix/control-center-template

Using the environment variable:

CONTROL_CENTER_CONFLUENT_CONTROLCENTER_KAFKA_MYCLUSTER_BOOTSTRAP_SERVERS=kafka:9092

Generates the following line in control center configuration file:

confluent.controlcenter.confluent.controlcenter.kafka.mycluster.bootstrap.servers=kafka:9092

The expected value is:

confluent.controlcenter.kafka.mycluster.bootstrap.servers=kafka:9092

I am going to propose a pull request to solve this case.

rancp commented 6 years ago

@angelbarrera92 if you just use CONTROL_CENTER_KAFKA_MYCLUSTER_BOOTSTRAP_SERVERS it should generate confluent.controlcenter.kafka.mycluster.bootstrap.servers

angelbarrera92 commented 6 years ago

@rancp Good Morning.

Thanks! seems to work!

Solved!