Closed rmoff closed 5 years ago
one comment, otherwise LGTM
thanks @wicknicks - I can't see the comment though?
Also is master
the correct branch to target, or should this be a 5.3 branch (if so which?) if we want it in the docker image released for 5.3?
Replaced by #765
Apache Kafka 2.3 added support for MDC in logs. For reasons of backward compatibility, it is disabled in log output by default.
This PR adds a new env variable to the Kafka Connect base image so that users can enable the MDC output in logs.
Changes
CONNECT_LOG4J_APPENDER_STDOUT_LAYOUT_CONVERSIONPATTERN
added as an optional environment variable. If present, the value provided is used inlog4j.appender.stdout.layout.ConversionPattern
ofconnect-log4j.properties
Testing done
test 01 : No change to existing environment variables
Log config
connect-log4j.properties
generated exactly as beforetest 02 : Add env var
CONNECT_LOG4J_APPENDER_STDOUT_LAYOUT_CONVERSIONPATTERN
Log config
connect-log4j.properties
generated with specified patternMDC information present in generated log