search

confluentinc / cp-docker-images

[DEPRECATED] Docker images for Confluent Platform.
Apache License 2.0
1.14k stars 704 forks source link

Fix plugin path #775

Closed rmoff closed 5 years ago

rmoff commented 5 years ago

This PR sets the CONNECT_PLUGIN_PATH environment variable as part of the docker image for those in which connectors are installed (enterprise-replicator, server-connect, kafka-connect). Without it the user must remember to set it themselves (and be expected to know the value to which it should be set) otherwise their connectors will fail with Class errors.

See Slack discussion here https://confluent.slack.com/archives/C5M8DKXJT/p1564768380084400

rmoff commented 5 years ago

@agam I've squashed the commits, can you approve?

rhauch commented 5 years ago

Okay, so I traced more about how this is being set up. It does look like the https://github.com/confluentinc/cp-docker-images/blob/5.3.0-post/examples/multi-datacenter/docker-compose.yml sets CONNECT_PLUGIN_PATH: /usr/share/java, and I cannot see where the Replicator executable run via the Docker image is properly setting the plugin path.

So, we need to set CONNECT_PLUGIN_PATH: /usr/share/java in these places.

ewencp commented 5 years ago

Since both the commits inside this PR have the same description, please either (1) squash them, or (2) add a bit more to each to distinguish them (Add plugin path ENV for ...)

For reference, you generally don't need to do this manually anymore if you don't want to. Use the Squash and merge option when merging and GH does it for you. Usually shouldn't be an issue since PR should be small and self contained.

rmoff commented 5 years ago

@rhauch am I ok to merge this change? thanks.