search

confluentinc / cp-docker-images

[DEPRECATED] Docker images for Confluent Platform.
Apache License 2.0
1.14k stars 704 forks source link

add snapshot.trust.empty and admin.enableServer to zookeeper.properties.template #824

Closed sawanoboly closed 1 year ago

sawanoboly commented 4 years ago

Hi,

I've checked upgrade guide to upgrade 5.3 to 5.4. It turns out that we need to add snapshot.trust.empty to the zookeeper config.

https://docs.confluent.io/current/installation/upgrade.html#additional-zk-upgrade-information

This PR adds snapshot.trust.empty and admin.enableServer to zookeeper.properties.

ghost commented 4 years ago

It looks like @sawanoboly hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

sawanoboly commented 4 years ago

[clabot:check]

ghost commented 4 years ago

@confluentinc It looks like @sawanoboly just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

ethicalmohit commented 4 years ago

Kindly merge this. It is required.

OneCricketeer commented 4 years ago

Can these not be added from Java properties?