search

confluentinc / cp-helm-charts

The Confluent Platform Helm charts enable you to deploy Confluent Platform services on Kubernetes for development, test, and proof of concept environments.
https://cnfl.io/getting-started-kafka-kubernetes
Apache License 2.0
787 stars 847 forks source link

Ksql-server and StatefulSet #307

Open HungUnicorn opened 5 years ago

HungUnicorn commented 5 years ago

Would it be useful to provide a helm chart for ksql-server that use statefulset?

gAmUssA commented 5 years ago

I think it makes sense. @HungUnicorn do you want to take a stab on this PR?

HungUnicorn commented 5 years ago

cool, I would like to. I have a question here, do you think it make sense to replace directly deployment.yaml in cp-ksql-server folder, with statefulset.yaml ? or let both charts exit?

jinoobaek-qz commented 5 years ago

Just curious. Is the desire to make statefulset coming from the fact that it takes a longer time to regenerate the local state store in the event of failure?

gAmUssA commented 5 years ago

@jinoobaek-qz check Gwen and Matthias talk from Kafka Summit. They were talking about Kstreams but also applicable to ksql https://www.confluent.io/kafka-summit-sf18/deploying-kafka-streams-applications. They covered both stateful and stateless deployments.

jinoobaek-qz commented 5 years ago

Very helpful. Thanks!

gAmUssA commented 5 years ago

@HungUnicorn, @jinoobaek-qz would either of you able to work on this?

jinoobaek-qz commented 5 years ago

Unfortunately, I do not have bandwidth to work on this at the moment.

HungUnicorn commented 5 years ago

@gAmUssA I will send a PR. Basically will use the same approach as kafka's statefulset, that the user can decide by persistence.enable in values.yaml