search

confluentinc / cp-helm-charts

The Confluent Platform Helm charts enable you to deploy Confluent Platform services on Kubernetes for development, test, and proof of concept environments.
https://cnfl.io/getting-started-kafka-kubernetes
Apache License 2.0
790 stars 843 forks source link

Heath check #309

Open lduparc opened 5 years ago

lduparc commented 5 years ago

Add liveness/readiness probe to deployment/statefulSets to ensure pods are up & running.

the-scott-hand commented 5 years ago

I would also like liveness/readiness probes for the deployment/statefulSets. I want to be able to verify that kafka is ready before my subscriber starts. I have been doing this using an init container to curl the http endpoint for other components readiness probes, so specifically I would like to see a readiness probe and liveness probe with an httpGet field like so: livenessProbe: httpGet: path: /healthz port: 8080 see: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/

the-scott-hand commented 5 years ago

any word on this?

nicknezis commented 5 years ago

Ping. This seems like a very critical feature that is needed.

the-scott-hand commented 5 years ago

Looks like this kafka helm chart has readiness and liveliness probes implemented, https://github.com/helm/charts/blob/master/incubator/kafka/templates/statefulset.yaml#L87-L116

leshibily commented 4 years ago

any updates on this?

hershdhillon commented 4 years ago

This feature should be added. The pods despite failing to make connections will perpetually run if there are no liveness probes included.

efinnestt commented 2 years ago

I was in shock when I discovered this chart has no liveness/readiness check