search

confluentinc / cp-helm-charts

The Confluent Platform Helm charts enable you to deploy Confluent Platform services on Kubernetes for development, test, and proof of concept environments.
https://cnfl.io/getting-started-kafka-kubernetes
Apache License 2.0
789 stars 846 forks source link

Customizable name for headless service #376

Open RobGeurds opened 4 years ago

RobGeurds commented 4 years ago

In cp-helm-charts/charts/cp-kafka/templates/headless-service.yaml there is the following part:

metadata: name: {{ template "cp-kafka.fullname" . }}-headless

This forces any service to have a name xxx-headless which results in usage of this helm chart being unviable for my team unless I ask our devs to change a large number of services. Usage of the helm chart would save me a lot of hassle though.

Is it possible to change this into a fully customizable name? For instance having a variable headlessServiceNameOverride or something along those lines?

krichter722 commented 4 years ago

This is also relevant for migration from other charts to the Confluence chart which is probably something that Confluence wants to make as smooth as possible.

I'm willing to work on it and provide a PR. Before, I'd like to have get a feedback from the devs, though.