search

confluentinc / demo-scene

👾Scripts and samples to support Confluent Demos and Talks. ⚠️Might be rough around the edges ;-) 👉For automated tutorials and QA'd code, see https://github.com/confluentinc/examples/
https://developer.confluent.io
Apache License 2.0
1.5k stars 896 forks source link

Pacman Demo - Profile page and Monetization Pop-up #226

Closed jcrabb-confluent closed 2 years ago

jcrabb-confluent commented 3 years ago

The Profile page uses a new stream to show average stats per life per user

The Monetization pop up asks the user to watch an ad for a free life and sends their choices to a stream for farther analysis.

You can watch the demo with Kai here; https://videos.confluent.io/watch/aDr3o5V2ChD83AJaXLAgKZ

jcrabb-confluent commented 3 years ago

@gianlucanatali here is my PR, please review

gianlucanatali commented 3 years ago

Another thing that I have noticed, is that the PROFILE Page is not showing anything if you enter it before dying. Maybe catch the error (i see one in the console) and show the scores as N/D or 0 ?

gianlucanatali commented 3 years ago

if you can give me write access to the repo/branch... so I can improve the popup with an ad if I have time ;)

jcrabb-confluent commented 3 years ago

You’re going to expose my lack of coding/github experience :D I tried to add you as a contributor to my fork, not sure if that is enough.

I will look to work on these other pieces. FYI, TODO is a way I define low-priority notes to myself so I can ctrl-F and look for them later. Do you have suggestions for an alternative?

On Sep 3, 2021, at 4:17 AM, Gianluca Natali @.***> wrote:

if you can give me write access to the repo/branch... so I can improve the popup with an ad if I have time ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/confluentinc/demo-scene/pull/226#issuecomment-912390966, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOF5I7XDR6KIYOA5NESOWLUACHDXANCNFSM5CZFVURA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rmoff commented 2 years ago

@jcrabb-confluent @gianlucanatali is this still active or can it be closed?

jcrabb-confluent commented 2 years ago

@rmoff I apologize - this has been out of sight, out of mind for me. I should be able to make the necessary changes with our "days off" tomorrow and Friday.

rmoff commented 2 years ago

I'm going to close this for now, please re-open as needed.