search

confluentinc / demo-scene

👾Scripts and samples to support Confluent Demos and Talks. ⚠️Might be rough around the edges ;-) 👉For automated tutorials and QA'd code, see https://github.com/confluentinc/examples/
https://developer.confluent.io
Apache License 2.0
1.5k stars 896 forks source link

Replace old java-faker with kotlin-faker #248

Open serpro69 opened 2 years ago

serpro69 commented 2 years ago

Replaced an old and buggy java-faker with kotlin-faker :) Probably not much of a difference for a demo, but it's my first contribution here, so hopefully it's ok :)

Tests in event-driven-microservices-workshop module still fail, but they were failing even before this change, so I assume it's intentional, since this is a workshop code.

ybyzek commented 2 years ago

@serpro69 for my own education, can you please elaborate on why Kotlin Faker is a better replacement (beyond "old and buggy java-faker")?

@MichaelDrogalis from your work on https://github.com/MichaelDrogalis/voluble which uses Java Faker , do you have an opinion on this PR?

serpro69 commented 2 years ago

Hi @ybyzek , kotlin faker offers more data providers, locales, and has extra "batteries" included as well - random instances of classes, unique values, etc. In addition to the above it's also faster. You can also check some comparisons here if you're interested ;)

rmoff commented 2 years ago

ping @MichaelDrogalis @ybyzek for input here plz

rmoff commented 2 years ago

@MichaelDrogalis any thoughts on this? thanks!