Open hachikuji opened 9 years ago
Both of these are reasonable. This has come up a couple of times recently and the better solution is to just move services over to using pid
files. I think the existing approach was mainly based off of the kafka bin scripts which use the janky ps
+ grep
approach.
For java processes with very long classpath options (such as those in the kafka command line tools), the full command is truncated in the process list, which makes the
ps ax | grep {name}
strategy ineffective. A more reliable option might be to usejps
. I also noticed thatkill_process
currently only works for java processes. It might be better to makekill_process
generic and include a java-specifickill_java_process
so that ducktape can work with non-java processes.