search

confluentinc / ducktape

System integration and performance tests
12 stars 93 forks source link

Fix test file discovery regression #285

Closed vp-elitnet closed 2 years ago

vp-elitnet commented 2 years ago

Proposed fix for #284.

imcdo commented 2 years ago

looks good, but before this gets merged in, I would like it if you could add documentation for this behavior as it could be a bit unclear if someone can run a test individually but it not be collected when specifying its parent directory https://github.com/confluentinc/ducktape/blob/master/docs/run_tests.rst

stan-is-hate commented 2 years ago

Thanks for finding the issue and a suggested fix! Can you please also add a test to ensure that passing the folder with a mix of test and non-test files still behaves as expected (ie non-test files are ignored)? Thanks!

vp-elitnet commented 2 years ago

Added behaviour clarification in "Running Tests" section.

Can you please also add a test to ensure that passing the folder with a mix of test and non-test files still behaves as expected (ie non-test files are ignored)?

Added a minimal additional mock test module to verify this case.