Runner Client Minor Refactor and Test

confluentinc / ducktape

System integration and performance tests

10 stars 93 forks source link

Runner Client Minor Refactor and Test #366

Closed imcdo closed 1 year ago

imcdo commented 1 year ago

The biggest change here to operations is organizational, the runner still calls run_client which does the same thing as before, but now ready has been extracted from the constructor, this way the constructor doesn't make any network calls.

Also for modern python development typing is now being used, and we have a specific runner client unit test.

Also for this tests mocks have been improved.

For typing reasons, Sender has been moved to the top of the file.

stan-is-hate commented 1 year ago

A proper review is underway, but a couple of quick points:

thanks for taking this on! I might be a pain during the review process, but doesn't mean this effort is not appreciated ;)
definitely need a minor version bump for this