confluentinc / ducktape

System integration and performance tests
16 stars 98 forks source link

Stop the hanging threads in runner client forcefully after 30 seconds #416

Closed sprsi closed 4 weeks ago

sprsi commented 1 month ago

Multiple threads are spawned while running tests and ultimately all of them need to join() to finish and publish the results (be it a success or a failure). However, if one or more threads don’t join(), they will eventually complete but the timing is non-deterministic. This PR solves this join() issue (or rather harden the runner client threading mechanism)

confluent-cla-assistant[bot] commented 1 month ago

:tada: All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

cla-assistant[bot] commented 1 month ago

CLA assistant check
All committers have signed the CLA.

PrasanthV454 commented 1 month ago

can you update the CODEONWERS file and add cp-test-frameworks team.

sprsi commented 1 month ago

@PrasanthV454 For now I've added them in review, in separate PR will make the change today.

prayadav-cp commented 1 month ago

@sprsi : Can you plz add sample semaphore job runs - 1 with upgrade tests and 1-2 with system tests (across branches say 7.3.x and 7.6.x) using this commit to ensure there is no regression.

sprsi commented 4 weeks ago

@prayadav-cp These are the runs on the new branch, looks good to me!

7.3.x run > https://semaphore.ci.confluent.io/jobs/f6a83864-e7c1-453a-9662-aa8b9e8a0e58/summary?report_id=0356f43b-c807-318c-b61e-09e8fdd4e976

7.4.x run > https://semaphore.ci.confluent.io/jobs/9560d05c-d72f-4acf-be8b-6cb92b32352e/summary?report_id=0356f43b-c807-318c-b61e-09e8fdd4e976

7.6.x run > https://semaphore.ci.confluent.io/jobs/8e6d69c8-fd37-417e-ab4b-c65b8a1d460f/summary?report_id=0356f43b-c807-318c-b61e-09e8fdd4e976

7.8.x run > https://semaphore.ci.confluent.io/jobs/0ef8557f-95e6-427d-8e1b-da18011f796c/summary?report_id=0356f43b-c807-318c-b61e-09e8fdd4e976

Upgrade job > https://semaphore.ci.confluent.io/workflows/d310a2b2-4c69-4838-8d4e-2c805db73da2?pipeline_id=8286af7a-3050-4f25-80e5-d6f1ca49b400