search

confluentinc / event-streaming-patterns

A collection of Event Streaming Patterns, including problem statements, solutions, and implementation examples.
Apache License 2.0
13 stars 6 forks source link

Idempotent Reader #185

Closed ybyzek closed 3 years ago

ybyzek commented 3 years ago

Description

101

@miguno @benstopford please note the subtle name change from Receiver to Reader, let me know if you agree.

Idempotent Writer: https://github.com/confluentinc/event-streaming-patterns/pull/204 Idempotent Reader: https://github.com/confluentinc/event-streaming-patterns/pull/185

New Pattern Checklist

ybyzek commented 3 years ago

@benstopford when you have a chance, would appreciate your review of this pattern as well 🙇‍♀️

ybyzek commented 3 years ago

@benstopford these patterns are ready for re-review, thank you!

Idempotent Writer: #204 Idempotent Reader: #185

rspurgeon commented 3 years ago

@rspurgeon can you please comment on

1. Whether the svg file looks right?  In my view, when I open it up locally, I see the heading with the pattern title, but I also know you did some file modification that maybe makes it render differently.

2. Does the `docs/meta.yml` file need to be manually updated?  I remember there was some discussion back with you and @krisajenkins on this, but this PR was created before that question was brought up.
  1. When I look at the pattern in locally served mkdocs (mkdocs serve), the diagram LGTM
  2. @krisajenkins can you comment on question 2? I can't recall where we landed with this
krisajenkins commented 3 years ago

@ybyzek @rspurgeon Yes, it definitely needs to be updated for new patterns to appear on the site.