search

confluentinc / examples

Apache Kafka and Confluent Platform examples and demos
Apache License 2.0
1.92k stars 1.12k forks source link

ccloud_library.sh uses hardcoded cloud provider and region for schema registry deployment #704

Closed mkieboom closed 4 years ago

mkieboom commented 4 years ago

The ccloud_library.sh script in the utils folder has hardcoded cloud provider (aws) and region (us) for the cloud schema registry deployment. eg: OUTPUT=$(ccloud schema-registry cluster enable --cloud aws --geo us -o json)

Which should be as below as per my understanding of the code: OUTPUT=$(ccloud schema-registry cluster enable --cloud $SCHEMA_REGISTRY_CLOUD --geo $SCHEMA_REGISTRY_GEO -o json)

I'll provide a pull request to fix this. Bare with me if that goes well as it has been a while since I've done that :-)

ybyzek commented 4 years ago

@mkieboom great catch! Thanks for reporting and fixing 🥇

mkieboom commented 4 years ago

Merged.