search

confluentinc / examples

Apache Kafka and Confluent Platform examples and demos
Apache License 2.0
1.92k stars 1.12k forks source link

KSQL Statements Should now include "EMIT CHANGES" for ksqlDB (.sql files) #756

Open chuck-confluent opened 4 years ago

chuck-confluent commented 4 years ago

There was a breaking syntax change when KSQL became ksqlDB where push queries are now specified with EMIT CHANGES; at the end. It seems there are several .sql files in various examples that do not respect the new usage of EMIT CHANGES for push queries

ybyzek commented 4 years ago

@chuck-confluent all the demos have been validated up to 6.0.x so can you please elaborate on what is the failure?

chuck-confluent commented 4 years ago

@ybyzek I wasn't running code, but just browsing and noticed for example, https://github.com/confluentinc/examples/blob/5.5.1-post/clickstream/ksql/ksql-clickstream-demo/demo/statements.sql has no "EMIT CHANGES." I apologize if I'm missing something obvious. I tried searching if there is perhaps a script that dynamically adds in "EMIT CHANGES", but there isn't as far as I could tell, and even if there were, it would probably be better to have the syntax directly in the statements.sql file