confluentinc / ide-sidecar

Sidecar application used by Confluent for VS Code, as a local proxy for Confluent Cloud, Confluent Platform and local Kafka clusters, to help users build streaming applications.
Apache License 2.0
3 stars 3 forks source link

Refactor Consume API to work for Native Kafka #112

Closed rohitsanj closed 2 weeks ago

rohitsanj commented 3 weeks ago

Summary of Changes

Refactor Consume API to work for Native Kafka rather than specifically for Confluent Local. This will be useful once we wish to consume topics using the yet-to-be-added "Direct" connection types.

Functional changes

We now try to JSON parse non-schema'd record key/value data instead of returning the string representation of it. A few tests have been updated to reflect this change.

Any additional details or context that should be provided?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

rohitsanj commented 2 weeks ago

@rhauch @flippingbits I've added some explanatory/clarifying documentation in the latest commit. Please have a look, thanks!