search

confluentinc / kafka-connect-datagen

Connector that generates data for demos
Apache License 2.0
20 stars 87 forks source link

DEVX-1034 add a Dockerfile for kafka-connect-datagen inside Operator #37

Closed rspurgeon closed 5 years ago

rspurgeon commented 5 years ago

Can we also add a note into the README?

Sure. I'm not certain what details to add, something in particular you were thinking of? FWIW, as mentioned in above comment, I think we should extend the makefile to build & publish all the images w/ standard versions, etc... so maybe with that change I can add some extended documentation to the README?

ybyzek commented 5 years ago

Sure. I'm not certain what details to add, something in particular you were thinking of? FWIW, as mentioned in above comment, I think we should extend the makefile to build & publish all the images w/ standard versions, etc... so maybe with that change I can add some extended documentation to the README?

Maybe copy make publish into something like make publish-operator?

publish-operator: package ## Publishes packages to Dockerhub for Operator
    docker build . -f Dockerfile-operator -t cnfldemos/cp-server-connect-operator-with-datagen:$(shell make version)
    docker push cnfldemos/cp-server-connect-operator-with-datagen:$(shell make version)

Also, we should use the same convention for tag names between the two repos:

  1. cnfldemos/kafka-connect-datagen
  2. cnfldemos/cp-server-connect-operator-with-datagen

However they have different formats right now, e.g. 0.1.3-5.3.0 vs 5.3.0.0_0.1.3

Can we change cp-server-connect-operator-with-datagen to match kafka-connect-datagen?

rspurgeon commented 5 years ago

Sure. I'm not certain what details to add, something in particular you were thinking of? FWIW, as mentioned in above comment, I think we should extend the makefile to build & publish all the images w/ standard versions, etc... so maybe with that change I can add some extended documentation to the README?

Maybe copy make publish into something like make publish-operator?

publish-operator: package ## Publishes packages to Dockerhub for Operator
  docker build . -f Dockerfile-operator -t cnfldemos/cp-server-connect-operator-with-datagen:$(shell make version)
  docker push cnfldemos/cp-server-connect-operator-with-datagen:$(shell make version)

Also, we should use the same convention for tag names between the two repos:

1. cnfldemos/kafka-connect-datagen

2. cnfldemos/cp-server-connect-operator-with-datagen

However they have different formats right now, e.g. 0.1.3-5.3.0 vs 5.3.0.0_0.1.3

* kafka-connect-datagen uses dash whereas cp-server-connect-operator-with-datagen uses underscore

* kafka-connect-datagen uses connector then connect version whereas cp-server-connect-operator-with-datagen uses the reverse connect then connector version

Can we change cp-server-connect-operator-with-datagen to match kafka-connect-datagen?

I agree with addressing these, however, since our operator demo uses this existing tag, can we make the transition in the 5.3.1 changes in that repo, and I'll do work here on the docs, makefiles, and Dockerfiles in a separate PR to get it all aligned?

ybyzek commented 5 years ago

I agree with addressing these, however, since our operator demo uses this existing tag, can we make the transition in the 5.3.1 changes in that repo, and I'll do work here on the docs, makefiles, and Dockerfiles in a separate PR to get it all aligned?

Can you use this PR as that vehicle?

rspurgeon commented 5 years ago

I agree with addressing these, however, since our operator demo uses this existing tag, can we make the transition in the 5.3.1 changes in that repo, and I'll do work here on the docs, makefiles, and Dockerfiles in a separate PR to get it all aligned?

Can you use this PR as that vehicle?

Sure, but i'll just close and start a new one so it's referenced under the proper jira