confluentinc / kafka-connect-jdbc

Kafka Connect connector for JDBC-compatible databases
Other
1.01k stars 954 forks source link

Rename method releaseLocksQuietly to commitQuietly #1303

Closed rajdangwal closed 1 year ago

rajdangwal commented 1 year ago

Problem

The method name was confusing. We are only calling the commit method inside releaseLocksQuietly. Releasing the acquired locks is a side-effect of commit call.

Solution

Renamed the method to commitQuietly.

Does this solution apply anywhere else?
If yes, where?

Test Strategy

Testing done:

Release Plan