confluentinc / kafka-connect-jdbc

Kafka Connect connector for JDBC-compatible databases
Other
1.01k stars 953 forks source link

CC-19476: Remove logic to trim sensitive logs from JDBC Sink Connector #1336

Closed ManasjyotiSharma closed 1 year ago

ManasjyotiSharma commented 1 year ago

Problem

CC-19476: It has bit of a history: Originally started off as RCCA-9573. At that time logredactor had a limitation w.r.t redacting exceptions (AUDIT-1057). Thus to mitigate the RCCA; as a stop gap fix; we added the redaction logic within JDBC Sink Connector itself (CCDB-5222). However that has later caused another RCCA viz. RCCA-10437. Given that AUDIT-1057 is fixed now; thus we will be leveraging logredactor rules and hence reverting back the previous stop gap fix from JDBC Sink Connector.

Solution

Reverting the code changes done as part of CCDB-5222; instead will be leverging logredactor rules to redact exceptions. As noted in CC-18288; logredactor changes are already deployed.

Does this solution apply anywhere else?
Testing done:

Note: Will be doing additional testing in devel to validate the logredactor rules before deploying this current JDBC Sink changes into prod.

ManasjyotiSharma commented 1 year ago

Thanks @b-goyal for reviewing and approving. As per this comment I'll not merge this PR for now. Moreover I have found a limitation of current logredactor's exception redaction capability (ref). As such I am closing this PR for now so that accidently it does not get merged! I'll reopen this PR once all logredactor fixes/rules are deployed and we observe them to be working fine.