Fix underflow issue with Oracle JDBC

confluentinc / kafka-connect-jdbc

Kafka Connect connector for JDBC-compatible databases

Other

1.01k stars 953 forks source link

Fix underflow issue with Oracle JDBC #1338

Closed ngupta0205 closed 1 year ago

ngupta0205 commented 1 year ago

Problem

https://confluentinc.atlassian.net/browse/RCCA-12408

Solution

https://github.com/jOOQ/jOOQ/issues/7548

Does this solution apply anywhere else?

[ ] yes
[x ] no

If yes, where?

Test Strategy

Testing done:

[ ] Unit tests
[x ] Integration tests
[ ] System tests
[ ] Manual tests

Release Plan

ManasjyotiSharma commented 1 year ago

Thanks for writing the PR @ngupta0205. Couple of points around testing:

Please update the PR description with the testing strategy you followed (to verify the fix).
If not already there; please add relevant tests into OracleDatatypeIT for the newly added FLOAT32/FLOAT64 scenarios.

ManasjyotiSharma commented 1 year ago

@ngupta0205 additionally I see that the jenkins build stage is failing - can you please look at that?

ManasjyotiSharma commented 1 year ago

BTW @ngupta0205 this seems more of a bug fix so a patch version update should suffice. Can you please change the target branch accordingly instead of master?

ngupta0205 commented 1 year ago

BTW @ngupta0205 this seems more of a bug fix so a patch version update should suffice. Can you please change the target branch accordingly instead of master?

@ManasjyotiSharma Added the IT for this and changed the base branch to 10.7.x. PTAL.

ManasjyotiSharma commented 1 year ago

@ngupta0205 LGTM; thanks for writing the PR!