confluentinc / kafka-connect-jdbc

Kafka Connect connector for JDBC-compatible databases
Other
1.01k stars 953 forks source link

Added zero-retries in JDBC source and unit test. #1341

Open Schm1tz1 opened 1 year ago

Schm1tz1 commented 1 year ago

Problem

JDBC source does not respect query.retry.attempts = 0, also see https://github.com/confluentinc/kafka-connect-jdbc/issues/1340

Solution

Added handling for the case with zero retries to fail without retries and added a unit test.

Does this solution apply anywhere else?
If yes, where?

Test Strategy

Added unit test and did local integration testing as well as testing with customers in their system.

Testing done:

Release Plan

cla-assistant[bot] commented 11 months ago

CLA assistant check
All committers have signed the CLA.