search

confluentinc / kafka-connect-storage-common

Shared software among connectors that target distributed filesystems and cloud storage.
Other
3 stars 154 forks source link

Minor: Fix build errors #302

Closed aniketshrimal closed 1 year ago

aniketshrimal commented 1 year ago

Problem

There are two issues we are fixing here -

  1. Not able to access ${confluent.maven.repo} property. 

    [ERROR]     Non-resolvable parent POM for io.confluent:kafka-connect-storage-common-parent:10.0.17-SNAPSHOT: Could not transfer artifact io.confluent:common:pom:6.1.9 from/to confluent (${confluent.maven.repo}): Cannot access ${confluent.maven.repo} with type default using the available connector factories: BasicRepositoryConnectorFactory and 'parent.relativePath' points at wrong local POM @ line 21, column 13: Cannot access ${confluent.maven.repo} using the registered transporter factories: WagonTransporterFactory: Unsupported transport protocol -> [Help 2]

    Fix for this is already explained in this PR - https://github.com/confluentinc/kafka-connect-elasticsearch/pull/419

  2. Spotbugs error due to java version 17 - 

    [ERROR] Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:4.0.0:spotbugs (spotbugs) on project kafka-connect-storage-common: Execution spotbugs of goal com.github.spotbugs:spotbugs-maven-plugin:4.0.0:spotbugs failed: Java returned: 1 -> [Help 1]

Solution

  1. Fix for ${confluent.maven.repo} property is to remove the property variable and directly use the url at configured place.
  2. Fix for spotbugs is to pin java version 8 similar to other connectors by using docker-debian-jdk8 in jenkinsFile.
Does this solution apply anywhere else?
If yes, where?

Test Strategy

Testing done:

Release Plan