confluentinc / kafka-rest

Confluent REST Proxy for Kafka
https://docs.confluent.io/current/kafka-rest/docs/index.html
Other
2.25k stars 641 forks source link

Pin kafka version to 7.8.0-100122-ccs to fix SystemTime cannot be accessed from outside package #1274

Closed srpconfluent closed 3 weeks ago

srpconfluent commented 3 weeks ago

org.apache.kafka.common.utils.SystemTime qualifier has been changed from public to default https://github.com/apache/kafka/pull/16266 . This is causing compilation failure for io/confluent/kafkarest/SystemTime.java . We will pin 7.8.0-100122-ccs as kafka-clients version so that we don't hit the compilation failure and unblock the release.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.0:compile (default-compile) on project kafka-rest: Compilation failure
[ERROR] /home/semaphore/ce-kafka-images/.src/kafka-rest/kafka-rest/src/main/java/io/confluent/kafkarest/SystemTime.java:[21,62] org.apache.kafka.common.utils.SystemTime is not public in org.apache.kafka.common.utils; cannot be accessed from outside package

discussion : https://confluent.slack.com/archives/CM6PEBEGM/p1718345803878219?thread_ts=1718271424.003559&cid=CM6PEBEGM

cla-assistant[bot] commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 3 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

srpconfluent commented 3 weeks ago

@alok123t this is safe operation as we are just pinning a specific version in only in the release branch v0.7209.x-7.8.0-0-ce, similar to what we did in https://github.com/confluentinc/confluent-cloud-plugins/pull/780 , so we can merge this and run ce-kafka-images build and verify and unblock release.

Anyways i will request kafka-rest team to review the PR to double confirm.