search

confluentinc / kafka-tutorials

Tutorials and Recipes for Apache Kafka
https://developer.confluent.io/tutorials
Apache License 2.0
16 stars 90 forks source link

Shell dependency #89

Open rmoff opened 5 years ago

rmoff commented 5 years ago

Do we need to call out the dependency on bash? For example, this doesn't work in fish: 

$ statements=$(< src/statements.sql) && \
      echo '{"ksql":"'$statements'", "streamsProperties": {}}' | \
          curl -X "POST" "http://localhost:8088/ksql" \
               -H "Content-Type: application/vnd.ksql.v1+json; charset=utf-8" \
               -d @- | \
          jq
fish: Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
statements=$(< src/statements.sql) && \
                                    ^

Or is it sufficient to consider that any dev using a weird shell will be sufficiently aware of stuff like this?

MichaelDrogalis commented 5 years ago

We have a plan to change up all of these code sequences to something much more intuitive, and it'll knock out this issue at the same time. Thanks for calling this out though, it's another negative point to the current approach.