confluentinc / ksql

The database purpose-built for stream processing applications.
https://ksqldb.io
Other
83 stars 1.04k forks source link

Add more extensive tests for SqlFormatter #1571

Closed rodesai closed 4 years ago

rodesai commented 6 years ago

SqlFormatter converts a parsed sql statement back in to the sql text. KSQL uses this to generate statement text to be written to the command topic after inferring schemas. This class is not adequately tested atm. One option suggested by @apurvam is to extend the QueryValidationTests to test this by having them rewrite each query and ensure that the valid outputs are produced.

agavra commented 4 years ago

This is done as part of #3037