confluentinc / ksql

The database purpose-built for stream processing applications.
https://ksqldb.io
Other
128 stars 1.04k forks source link

Basic auth docs example fails with "unable to find LoginModule class" #5254

Closed vcrfxia closed 4 years ago

vcrfxia commented 4 years ago

Describe the bug

The removal of Jetty from the ksqlDB server (https://github.com/confluentinc/ksql/pull/5134) means the basic auth examples in our docs (https://docs.ksqldb.io/en/latest/operate-and-deploy/installation/server-config/security/#configure-ksqldb-for-basic-http-authentication) no longer work since the docs use org.eclipse.jetty.jaas.spi.PropertyFileLoginModule which is no longer packaged with the ksqlDB server.

This is the error message that results when a user tries to authenticate according to the example in the docs:

[2020-05-03 13:06:19,336] ERROR Failed to log in. unable to find LoginModule class: org.eclipse.jetty.jaas.spi.PropertyFileLoginModule (io.confluent.ksql.api.auth.JaasAuthProvider:117)

To Reproduce

Follow the docs linked above on the latest master.

Expected behavior

The docs example works.

Actual behaviour

Authentication fails with the error message above.

Additional context

Unless we want to add back the dependency, we should update the documentation with how to get the jar and add it to KSQL_CLASSPATH, including how to do this when running the ksqlDB server via docker image. It'd be nice to do this before the 0.9.0 release.

apurvam commented 4 years ago

@vcrfxia can you fix the docs?

purplefox commented 4 years ago

I agree, this looks like a docs issue.