search

confluentinc / ksql

The database purpose-built for stream processing applications.
https://ksqldb.io
Other
128 stars 1.04k forks source link

Figure out test strategy for ksql configs #566

Open apurvam opened 6 years ago

apurvam commented 6 years ago

As seen in #565, we broke the ability to configure the number of replicas for the command topic silently in a refactor.

We should figure out how to add tests so that this doesn't happen again.

rmoff commented 6 years ago

@apurvam I saw that #565 has been merged; does that mean this issue can be closed?

apurvam commented 6 years ago

@rmoff , thanks for checking. This has to do with the lack of tests which allowed the regression fixed by #565 to begin with.

cc @rodesai .. I think your recent patches might have added tests for this. Can you confirm?