search

confluentinc / ksql

The database purpose-built for stream processing applications.
https://ksqldb.io
Other
102 stars 1.04k forks source link

Bump the version of vertex-core dependency for ksqldb-rest-client #9227

Open letaoj opened 2 years ago

letaoj commented 2 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] We developed a wrapper around the ksqlDB rest client and our consumer directly consumes our client in their Java service. The io.vertx:vertx-core version that they are using is 4.1.0 which is incompatible with the version that used in ksql-rest-client v0.26.0. It appears that there is a breaking change introduce in 4.x.x which remove the put.(String, String) method and replaced with put.(String, Object) in JsonObject in instead.

Describe the solution you'd like A clear and concise description of what you want to happen. Bump the version of vertex dependency to 4.x.x

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. The current mitigation that we are taking is to downgrade the consumer's dependency to 3.9.12 so that our consumer is able to use the client.

Additional context Add any other context or screenshots about the feature request here.

agavra commented 2 years ago

Just to update this ticket, we have the feature code complete (#9234) but it's causing some tests to fail and dramatically increasing the time it takes to run our tests. I haven't been able to figure out why.

ghost commented 1 year ago

Facing the same issue. any updates on the same?? @letaoj @agavra using Vertx 4.x.x. getting the method not found for JsonObject.put().

ghost commented 1 year ago

@agavra I see a PR already merged for Vertx upgrade to 4.3 https://github.com/confluentinc/ksql/pull/9421/files#diff-b3029caf6c304b08346c5a6212ee84cb0a7f8edd64e4e2cab6d52709e12c287d Which version number is it released on ?