Some components use `strcmp` which is vulnerable to timing attacks

[HRsGIT]

Description

Some components in librdkafka use strcmp to validate a password, signature or key, which is vulnerable to timing attacks that make brute force attacks for such credentials more likely to be successful. For example, consider lines 842 and 567 in rdkafka_sasl_scram.c. A similar issue occurred with Apache Kafka, which has been assigned CVE-2021-38153. Patch in Apache Kafka Code in ibrdkafka

Checklist

IMPORTANT: We will close issues where the checklist has not been completed.

Please provide the following information:

• [x] librdkafka version (release number or git tag): [v2.3.0](https://github.com/confluentinc/librdkafka/releases/tag/v2.3.0)
• [x] Apache Kafka version: [3.7.0](https://github.com/apache/kafka/releases/tag/3.7.0)
• [x] librdkafka client configuration: no
• [x] Operating system: no
• [x] Provide logs (with debug=.. as necessary) from librdkafka
• [x] Provide broker log excerpts
• [x] Critical issue

[emasab]

I think it's very difficult to find a timing based brute force attack to guess ServerSignatureB64 from this. Even if the connecting broker is a Mallory. because the ServerSignatureB64 is calculated from AuthMessage that contains the client salt, that it's random. So ServerSignatureB64 changes at every connection attempt. Connection attempts start from a backoff of 100ms and reach a maximum of 10s.

Given that, I don't know if some kind of cryptographical analysis can be applied on top of this, could you explain how an attack would look like. Not a generic timing attack but for this specific field? The fix would be to compare all the bytes in the signature instead of stopping at first one that differs.