search

confluentinc / librdkafka

The Apache Kafka C/C++ library
Other
7.37k stars 3.11k forks source link

NONJAVACLI-3460: update third party dependencies #4690

Closed janjwerner-confluent closed 1 month ago

milindl commented 2 months ago

/sem-approve

milindl commented 2 months ago

Running CI, and then I'll run try running OIDC tests locally to test out the libcurl update.

janjwerner-confluent commented 2 months ago

@milindl Can we bump openssl while we're here or should I create another ticket /pr ?

milindl commented 2 months ago

I can bump it here, we're changing things anyway. However, openssl bumps are partial, linux only, because the latest versions of openssl 3.0.x are not available on vcpkg.

milindl commented 2 months ago

Closing and reopening this to try and make sem-approve work.

milindl commented 2 months ago

/sem-approve

milindl commented 2 months ago

In the latest changes (which include openssl bump):

  1. I compiled with ./configure --install-deps --source-deps-only --disable-lz4-ext --enable-static --enable-strip --disable-gssapi
  2. Ran all integration tests with interactive-broker-version 3.7.0
  3. Ran the OIDC integration test (the test seems to be failing for an unrelated reason, but the curl request/response is working correctly, I added some log statements to check the response. The test fails after that, there's something wrong in the broker that trivup has set up).
janjwerner-confluent commented 2 months ago

resolves ( with downstream propagation) https://github.com/confluentinc/librdkafka/issues/4653 https://github.com/confluentinc/librdkafka/issues/4664 https://github.com/confluentinc/confluent-kafka-dotnet/issues/2203

janjwerner-confluent commented 1 month ago

replacing the branch name to dev_janjwerner_deps_update per @milindl suggestion