confluentinc / librdkafka

The Apache Kafka C/C++ library
Other
303 stars 3.15k forks source link

KIP 848 ListGroups API #4777

Closed mahajanadhitya closed 3 weeks ago

pranavrth commented 3 months ago

Build is failing

mahajanadhitya commented 3 months ago

Build is failing

Do you have the warnings flag on, if so the warnings are not for my changes atleast. The build runs fine for me.

pranavrth commented 3 months ago

I am talking about Semaphore build in the PR.

pranavrth commented 3 months ago

Apart from this the test 0081 is crashing in my local as well when running with broker v3.7.0 with classic protocol.

mahajanadhitya commented 2 months ago

Librdkafka KIP 848 ListGroups API Branch Name : feature/ListGroupsAPI Example : examples/list_consumer_groups

Running the example : ./list_consumer_groups -b localhost:9092 state_cnt_int type_cnt_int [ state_1_int state_2_int ] [ type_1_int type_2_int ] Types can only be Consumer(1), Classic(2). Any other type int would give error as Unknown(0) is not accepted and others do not exist Types only populates the options for the request which MIGHT NOT BE USED by broker, depending on the version used.

Running the integration test(do_test_ListConsumerGroups) : TESTS=0081 make

Running the unit tests(do_test_ListConsumerGroups) : TESTS=0080 make

Any warnings via configure, make or make install are not subject to my changes.

Formatting done via, $ make style-fix

Integration Testing done with :

If any test fail, it is either because any consumer_group did not get destroy and had its information rolled over in the next spawn, or the Apache Kafka Version (trunk) instead of 3.8 or 3.7 ! I can discuss the same in the office hours as well !

confluent-cla-assistant[bot] commented 1 month ago

All contributors need to sign the Contributor License Agreement here before this PR can be approved.
:x: mahajanadhitya
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

pranavrth commented 3 weeks ago

Closed with https://github.com/confluentinc/librdkafka/pull/4860