search

confluentinc / librdkafka

The Apache Kafka C/C++ library
Other
303 stars 3.15k forks source link

Fix for an infinite loop in cooperative sticky assignor #4800

Closed emasab closed 1 month ago

emasab commented 3 months ago

when potential topic partitions are less than number of members.

Closes #4783

mensfeld commented 3 months ago

I can confirm this works :) I applied it via a patch in rdkafka-ruby and was not able to trigger it anymore. Thank you!

emasab commented 3 months ago

Thank you @mensfeld ! Couldn't push it earlier because we're reviewing company flows after the incident that happened to public repositories earlier in the month.

mensfeld commented 3 months ago

No worries. You motivated me to finally craft ability to patch librdkafka for rdkafka-ruby so now I can also expose the needed fork-protect APIs for MacOS. Thank you for all your hard work :pray:

confluent-cla-assistant[bot] commented 2 months ago

:tada: All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

mensfeld commented 1 month ago

@pranavrth I've been running a similar patch for this for weeks, I have specs in rdkafka-ruby and karafka. This solves it as I was able to reproduce it on my side in 100%.

pranavrth commented 1 month ago

@mensfeld - I was saying that we don't need a test for this kind of trivial bug.