search

confluentinc / librdkafka

The Apache Kafka C/C++ library
Other
303 stars 3.15k forks source link

Adding int identifier for transactional ID #4803

Closed JohnPreston closed 1 month ago

JohnPreston commented 3 months ago

Adding the int ID for transactional ID, to enable using that as a ResourceType in the clients (python being my use-case specifically)

cla-assistant[bot] commented 3 months ago

CLA assistant check
All committers have signed the CLA.

pranavrth commented 3 months ago

/sem-approve

JohnPreston commented 3 months ago

/sem-approve Well that was worth a shot :D @pranavrth can you please re-trigger the tests?

pranavrth commented 3 months ago

/sem-approve

JohnPreston commented 3 months ago

I mean, the style check I ran the command to fix that locally so I don't know what else to do here :/ I am not sure why the tests pass on some architecture but not with others. Given that the validation test is to check the value as per a statically expected set of returns, I am not sure how that comes to be.

Any suggestions?

pranavrth commented 3 months ago

The style check works with uncommitted and unstaged changes. Can you try to uncommit your changes and then run make style-fix-changed and then force push the changes to this branch after committing.

Test still fails. Failing on different architecture is not related to the test cases. Its something else that I can check later when the style check and tests passes. Please focus on the Linux Ubuntu x64: source build and Style check jobs in the CI.

Screenshot 2024-08-22 130127

pranavrth commented 1 month ago

Closing this PR. Continued in https://github.com/confluentinc/librdkafka/pull/4856