search

confluentinc / libserdes

Avro Serialization/Deserialization C/C++ library with Confluent schema-registry support
Apache License 2.0
5 stars 64 forks source link

Feature/add support for topic name strategy #19

Open shashankjain87 opened 5 years ago

shashankjain87 commented 5 years ago

In order to add support for topic name strategy (being the default for SchemaRegistry in Java), libserdes needs to allow registering the same schema under different names. The change checks for the name in the cache first. If absent, it is allowed to be registered/cached. If name is not provided defaults to the existing behavior.

This addresses issue raised earlier - https://github.com/confluentinc/libserdes/issues/10

ghost commented 5 years ago

It looks like @shashankjain87 hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

shashankjain87 commented 5 years ago

[clabot:check]

ghost commented 5 years ago

@confluentinc It looks like @shashankjain87 just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

lukejackson commented 5 years ago

Hi @edenhill - let us know if there is any feedback or any context required for this PR. We are building and using this internally at present.

lukejackson commented 4 years ago

@edenhill I see you've started some work on this repo recently. is now a good time to review this PR?