confluentinc / parallel-consumer

Parallel Apache Kafka client wrapper with per message ACK, client side queueing, a simpler consumer/producer API with key concurrency and extendable non-blocking IO processing.
https://confluent.io/confluent-accelerators/#parallel-consumer
Apache License 2.0
689 stars 118 forks source link

fix issue #787 for cannot close and exit properly when rebalancing storm #789

Closed sangreal closed 3 weeks ago

sangreal commented 3 weeks ago

Description... fix issue #787 for cannot close and exit properly when rebalancing storm.

Checklist

sangreal commented 3 weeks ago

I don't check if State is CLOSING or DRAINING is that it will deprive the interruption on waiting on mailbox queue. Therefore I follow currentlyPollingWorkCompleteMailBox as flag to avoid to be interrupted while waiting submitted tasks to be executed.

rkolesnev commented 3 weeks ago

/sem-approve

sangreal commented 3 weeks ago

@rkolesnev I have addressed your comments, please help check again. Thanks for the quick review.

rkolesnev commented 3 weeks ago

/sem-approve