search

confluentinc / terraform-provider-confluent

Terraform Provider for Confluent
Apache License 2.0
27 stars 63 forks source link

fix(docs): Update header in markdown files #312

Closed maximiliantech closed 11 months ago

maximiliantech commented 1 year ago

Hi everyone,

I reopened the force closed PR #308 because the other account was closed/deleted. To follow up on the discussion with @linouk23, we leave the PR open till the changes are included in the next release.

cla-assistant[bot] commented 1 year ago

CLA assistant check
All committers have signed the CLA.

linouk23 commented 1 year ago

@maximiliantech could you confirm it's a new line issue? image

or it might be a smart idea to update a header: image

maximiliantech commented 1 year ago

@linouk23 The two files (confluent_peering.md and confluent_transit_gateway_attachment.md) are totally fine in general. But I experienced that the Markdown file will not be rendered correctly with this first empty line. So I deleted the empty line in both files, since every other Markdown file does not have this first empty line. I did this to maintain consistency.

linouk23 commented 11 months ago

@maximiliantech I'm happy to let you know we applied this code change manually in the latest version 1.55.0.