search

confluentinc / terraform-provider-confluent

Terraform Provider for Confluent
Apache License 2.0
31 stars 64 forks source link

Wrong defaults in examples for flink #454

Closed loudbinary closed 1 month ago

loudbinary commented 1 month ago

Working through a Flink Example, and I've found a couple roles being used are throwing errors. I've did a bit of digging ande found other "sane" defaults.

Some digging led me to Operator - here, rather than EnvironmentAdmin.

Seems sane. Did we miss some name changes or role restructuring and refinement?

https://github.com/confluentinc/terraform-provider-confluent/blob/cf729532e18ccf1c2278204958d967040bd5dde7/examples/configurations/private-flink-quickstart/main.tf#L148

Similarly, but foor role I used OrganizationAdmin for this line here: https://github.com/confluentinc/terraform-provider-confluent/blob/cf729532e18ccf1c2278204958d967040bd5dde7/examples/configurations/private-flink-quickstart/main.tf#L89

If both seem same now for defaults in the example I can PR in a value change.

If these are not acceptable, then what should be used?

loudbinary commented 1 month ago

Figured this one out.

I was using a resource name from the organizations data object and not my environments data source object. So the wrong crn was presented for the environment scoped role request.