[0.16.x] fix(Windows): home dir lookup for document content provider - Githubissues

confluentinc / vscode

Confluent for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=confluentinc.vscode-confluent

Apache License 2.0

13 stars 3 forks source link

[0.16.x] fix(Windows): home dir lookup for document content provider #243

Closed shouples closed 1 month ago

shouples commented 1 month ago

Summary of Changes

Use os.homedir() instead of looking specifically for the HOME env var:

Returns the string path of the current user's home directory. On POSIX, it uses the $HOME environment variable if defined. Otherwise it uses the effective UID to look up the user's home directory. On Windows, it uses the USERPROFILE environment variable if defined. Otherwise it uses the path to the profile directory of the current user.

✅ gulp clicktested on darwin arm64 and win32 x64

Resolves https://github.com/confluentinc/vscode/issues/241

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests

[ ] Added new
[ ] Updated existing
[ ] Deleted existing

Other

[x] Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
[x] Have you validated this change locally by packaging and installing the extension .vsix file?
```
gulp clicktest
```