confluentinc / vscode

Confluent for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=confluentinc.vscode-confluent
Apache License 2.0
13 stars 4 forks source link

Insufficient contrast ratio for highlighted column in histogram #290

Open derek1ee opened 2 months ago

derek1ee commented 2 months ago

Code of Conduct

On what operating system are you seeing the problem?

macOS (Apple/arm64)

VS Code version

Version: 1.93.1 (Universal) Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40 Date: 2024-09-11T17:20:05.685Z Electron: 30.4.0 ElectronBuildId: 10073054 Chromium: 124.0.6367.243 Node.js: 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 22.6.0

Version of Confluent extension

v0.16.3

To Reproduce

  1. Install, signin to CC, and open a message viewer for topic.
  2. Search for a message based on some value
  3. Observe the DEX visual

Current vs. Expected behavior

Observe the bar where the filtered message is in is highlighted, but very, very dim.

Expect the highlight to have sufficient contrast to meet WCAG requirements.

image

Relevant log output

No response

Which area(s) are affected? (Select all that apply)

Messages

Additional context

No response

noeldevelops commented 1 month ago

color contrast ratios are hard with varied themes. We may need another pattern. @alexeyraspopov to follow up with design on "contrast/highlight" patterns

alexeyraspopov commented 1 month ago

@derek1ee @katehollowayconfluent any opinion about using stripes pattern?

image
alexeyraspopov commented 1 month ago

Per @katehollowayconfluent, we wait for design input