Mainly adjusts where we show the error notification so it can be invoked from isDockerAvailable() instead of as a follow-on call, so we can choose whether or not to inform the user about a specific response error (e.g. not meeting the minimum Docker engine API version) or a non-ResponseError type.
Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
[x] Added new
[x] Updated existing
[ ] Deleted existing
Other
[ ] All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
[ ] Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
[x] Have you validated this change locally by packaging and installing the extension .vsix file?
Summary of Changes
Closes #546.
Mainly adjusts where we show the error notification so it can be invoked from
isDockerAvailable()
instead of as a follow-on call, so we can choose whether or not to inform the user about a specific response error (e.g. not meeting the minimum Docker engine API version) or a non-ResponseError
type.Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Other
.vsix
file?