confluentinc / vscode

Confluent for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=confluentinc.vscode-confluent
Apache License 2.0
13 stars 3 forks source link

improve notifications when Docker is unreachable #569

Closed shouples closed 4 days ago

shouples commented 5 days ago

Summary of Changes

Closes #546.

Mainly adjusts where we show the error notification so it can be invoked from isDockerAvailable() instead of as a follow-on call, so we can choose whether or not to inform the user about a specific response error (e.g. not meeting the minimum Docker engine API version) or a non-ResponseError type.

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
Other