conformal / spectrwm

A small dynamic tiling window manager for X11.
ISC License
1.33k stars 96 forks source link

Add new `bar_color_unfocus` and `bar_font_color_unfocus` options. #528

Closed wavexx closed 1 year ago

wavexx commented 1 year ago

I wanted the bar of focused screens to 'pop' a little bit more. We can set the bar border color, but that didn't give me enough visual cue unless I made it too big.

For this reason I introduced two new options to change the foreground/background colors of the bar depending on the focused region which after a few tries I came to really like. This allowed me to disable the bar border completely. See this clip to see the behavior with two screens, alternating in focus:

https://www.thregr.org/~wavexx/tmp/spectrwm-test.webp (uploaded elsewhere due to gh refusing webp)

Both default to the same focused colors (without suffix), resulting in no change in behavior without the extra new customization.

I currently based this on release3.5 as I wanted to test the new tweaks to the region rotation flags, but I can rebase if needed.

wavexx commented 1 year ago

force-pushed to fix a typo in the manpage.

wavexx commented 1 year ago

Just a head's up, I noticed that this introduces a small regression when overprinting long strings such as titles on the right of the bar (since the bg color is not redrawn if unchanged). I'll have a look at this.

wavexx commented 1 year ago

We now set a clip rectangle on the bar fragment so that text overflow can't happen.

LordReg commented 1 year ago

These options fit nicely with bar_border_unfocus.