search

confuser / BarAPI

DEPRECATED Control Minecraft boss bar programatically
http://dev.bukkit.org/bukkit-plugins/bar-api/
Other
24 stars 48 forks source link

Added Scrolling v2 #51

Closed gpotter2 closed 8 years ago

gpotter2 commented 9 years ago

Modified the code of scrolling i made to gather players in only some threads: By default, there are only a thread for 10 players (this param can be changed) Added a color code handler for the scrolling Need: to add a param in the config for this parameter (located in ThreadManager)

gpotter2 commented 9 years ago

So, there will be less threads :)

confuser commented 9 years ago

As you're storing the Player object, but not removing it when a player leaves, it may cause a memory leak.

There's a few questionable changes here, but I'm going to pull this branch, compile and test it.

gpotter2 commented 9 years ago

All right !

gpotter2 commented 9 years ago

Ho, is this not removing the player ? ThreadManager l 120-121:

if(!BarAPI.hasBar(dp.fd.player)){ l.remove(i);

gpotter2 commented 9 years ago

And we still have to improve or change the reloadMessage void in BarAPI