congatudo / Congatudo

Cloud replacement for Conga vacuum robots enabling local-only operation
https://congatudo.cloud
Apache License 2.0
72 stars 22 forks source link

Segment cleanup timer not working #69

Closed miguesan01 closed 1 year ago

miguesan01 commented 1 year ago

Describe the bug

Timers with segment cleanup isn't working, in the log you can see that the timer is executed but an error is raised up. It only happens with segment cleanup timers , full cleanup timer always works like a charm. I have congatudo latest release installed (2023.03.0, downloaded from github, not compiled by me) in standalone mode.

To Reproduce

  1. Add segment cleanup timer.
  2. Wait until the timer's programed time is reached.
  3. Robot won't start cleanning, and error is reported in log.

Screenshots

photo_4_2023-03-22_11-15-21 photo_2_2023-03-22_11-15-21 photo_3_2023-03-22_11-15-21 photo_1_2023-03-22_11-15-21

Vacuum Model

Conga 3490

Congatudo Version

2023.03.0

Expected behavior

Segment cleanups timers starts cleaninng when rquired.

Additional context

miguesan01 commented 1 year ago

I successfully tried 2023.02.1 version, both segment and full clenup timers work as expected. The issue is only in latest version 2023.03.0

germanyague commented 1 year ago

It seems as something to do with zones as well. Versión 2023.03 doesn't let me clean by zones in a conga 3090 either. It says: 2023-04-13T13:08:40.445Z Warn ZoneCleaningCapabilityRouter: Error while handling route "/" { body: { action: 'clean', zones: [ { points: { pA: { x: 366, y: 464 }, pB: { x: 453, y: 464 }, pC: { x: 453, y: 534 }, pD: { x: 366, y: 534 } } } ], iterations: 1 }, message: 'options.map is not a function' }

However it works in version 2023.02.1. I'm talking about alpine inside docker.

elraro commented 1 year ago

@miguesan01 ¿puedes probar la nueva release 2023.04?

miguesan01 commented 1 year ago

@miguesan01 ¿puedes probar la nueva release 2023.04?

Lo siento, no va a poder ser. Compré un nuevo robot de otra marca y este ya no lo tengo, lo regalé.

germanyague commented 1 year ago

Yo he probado con la nueva versión y al menos a mi me sigue dando el mismo error, no se si son por la misma causa.

elraro commented 1 year ago

hola @germanyague

ya encontré el problema, está solucionado en el commit 25a7226a622adaa92a8fa5a3521ecd624c9122e0

O no... ha fallado la compilación, dejame que lo mire en casa con más calma, pero el problema está ahí.

Un saludo.

elraro commented 1 year ago

Ahora sí @germanyague jeje

Prueba las nightly a partir de mañana o compila tú mismo

elraro commented 1 year ago

@germanyague alguna novedad?

germanyague commented 1 year ago

Parece que no, con la última versión nightly:

Captura de pantalla 2023-05-01 a las 23 36 45

2023-05-01T21:36:43.723Z Warn ZoneCleaningCapabilityRouter: Error while handling route "/" { body: { action: 'clean', zones: [ { points: { pA: { x: 414, y: 411 }, pB: { x: 444, y: 411 }, pC: { x: 444, y: 441 }, pD: { x: 414, y: 441 } } } ], iterations: 1 }, message: "Cannot read properties of undefined (reading 'map')" }

elraro commented 1 year ago

Solved. Test the nightly release. Please, reopen the issue if you find any problem.