search

congo-cc / congo-parser-generator

The CongoCC Parser Generator, the Next Generation of JavaCC 21, which in turn was the next generation of JavaCC
https://discuss.congocc.org/
Other
33 stars 9 forks source link

Make visit(Node n) public #176

Closed adMartem closed 4 months ago

adMartem commented 4 months ago

So I can do things like this:

    @Override
    public void visit(Node node) {
        if (node == null || (!visitDirty && node.isDirty())) return;
       super. visit(node);
    }
adMartem commented 4 months ago

Apparently the test workflow doesn't work anymore. But since it seems to have failed on several previous commits, I'll merge it anyway. I can't see how this change could break anything, and it runs the tests on my machine. I haven't checked to see if a corresponding change is needed for Python and CSharp templates, but I think I'll stop with this pending resolution of the testing problem here.

revusky commented 4 months ago

Apparently the test workflow doesn't work anymore.

I'm sure it has nothing to do with making the visit method public. I don't understand why the tests aren't running. I'm going to count on Vinay to figure it out. I certainly don't understand why the core tests on the server are failing when I can run ant full-test successfully locally.