order method modifiers (public/private static final)

congo-cc / congo-parser-generator

The CongoCC Parser Generator, the Next Generation of JavaCC 21, which in turn was the next generation of JavaCC

https://discuss.congocc.org/

Other

36 stars 11 forks source link

order method modifiers (public/private static final) #29

Closed stbischof closed 1 year ago

stbischof commented 1 year ago

this was explicit not a bug. It helps developers that uses code analysis tools to see how good the quality of the generated parser-code is closes #20

revusky commented 1 year ago

Really, I'm doing this just to humor you. Well, it is true that it is a stylistic recommendation in the JLS to put the modifiers in that order. (Before this, I didn't even know that.) But it does also occur to me that, if this is the level of stuff that the style checker tool points out, there isn't really much problem with the code!

stbischof commented 1 year ago

With 1500 codesmells id does look bad when looking on the numbers. When looking in code it is understandable that that are just small things. Thats why i am fixing this and when this primitives are done maybe we find some relevant.