congo-cc / congo-parser-generator

The CongoCC Parser Generator, the Next Generation of JavaCC 21, which in turn was the next generation of JavaCC
https://discuss.congocc.org/
Other
36 stars 11 forks source link

Reproducible build - avoid changing method and imports order #34

Closed stbischof closed 4 months ago

stbischof commented 1 year ago

When build twice the order of the Imports in the Parser and the order of the methods change between two builds with same grammar.

revusky commented 1 year ago

If you try now, with the latest code, do you still have this problem?

stbischof commented 1 year ago

will build maven snapshot and test it in next hours.

stbischof commented 1 year ago

still in other order each time.

but https://parsers.org/download/congocc-full.jar . is from 20.04. maybe this does not hold the changes?

revusky commented 1 year ago

but https://parsers.org/download/congocc-full.jar . is from 20.04. maybe this does not hold the changes=

Well, no, it doesn't. (Or didn't. Now it does.)

You would have had to do (from the top-level directory where you checked out the code) git pull ant full-jar

stbischof commented 1 year ago

Still exist with build of 25.04.

you are using the unorderd HashSet instead of LinkedHashSet. i currently looking to this issue and try to fix it

stbischof commented 1 year ago

@revusky could you please release the Version to the Server?

revusky commented 1 year ago

@revusky could you please release the Version to the Server?

It is done.

You can also build with:

   git clone https://github.com/congo-cc/congo-parser-generator.git congo 
   cd congo
   ant full-jar
stbischof commented 1 year ago

Yes i build it this way Multiple times for the pr. But the maven build starts with a Download ;)

revusky commented 1 year ago

Actually, I just quickly went through and reverted some of the cases where it is glaringly obvious that it makes no difference if you use LinkedHashSet/Map or just the regular one. (Certainly, if you never iterate over the keys, it just makes no difference that you used LinkedHashMap, say.) I put up the resulting jarfile on the server.

stbischof commented 1 year ago

Great!

vsajip commented 7 months ago

Shall I close this now?

vsajip commented 4 months ago

Closed, as no contrary feedback received.