search

conicalflask / fs2

A sophisticated file sharing system for LAN parties with a focus on fast accurate searching, easy browsing and fast transfers.
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Default configuration builder appears to miss some items #13

Closed ghost closed 12 years ago

ghost commented 12 years ago

Here are the log lines after a fresh boot which make me think the fresh config builder and the actual configuration items might not be tightly integrated:-

2012.08.08 19:39:28 WARNING: Configuration item: 'gui/files_table_columnwidths/col0' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/files_table_columnwidths/col1' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/files_table_columnwidths/col2' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/downloadchunks_table_columnwidths/col0' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/downloadchunks_table_columnwidths/col1' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/downloadchunks_table_columnwidths/col2' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/downloadchunks_table_columnwidths/col3' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/downloadchunks_table_columnwidths/col4' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/downloadchunks_table_columnwidths/col5' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/uploads_table_columnwidths/col0' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/uploads_table_columnwidths/col1' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/uploads_table_columnwidths/col2' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/uploads_table_columnwidths/col3' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/uploads_table_columnwidths/col4' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/uploads_table_columnwidths/col5' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/stats_indexnodes_table_columnwidths/col0' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/stats_indexnodes_table_columnwidths/col1' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/stats_indexnodes_table_columnwidths/col2' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/stats_indexnodes_table_columnwidths/col3' must be numeric, but it's not. Assuming zero. 2012.08.08 19:39:28 WARNING: Configuration item: 'gui/stats_indexnodes_table_columnwidths/col4' must be numeric, but it's not. Assuming zero.

Not exactly a massive issue, but might be nice to tidy up.

conicalflask commented 12 years ago

I expect, given the context that this is not at config initialisation time but is when the gui tries to read the stored column widths that don't exist. Where it's non-numeric because it doesn't exist it should silently return the default (0) rather than warn.

I'm not sure if you were implying that the initial configuration should contain column widths, but I don't think it's appropriate for it to.

conicalflask commented 12 years ago

Fixed so it doesn't bother the console for this as it's not a bug.