Closed vqhuy closed 7 years ago
LGTM
I think it would be helpful to put some comments in the config.toml as well.
LGTM, too. I agree with @arlolra, comments in the config.toml would be helpful for someone who isn't familiar with toml files.
I just remembered that I have tried to encode comments to generated TOML files as well, but I haven't found any way, unfortunately.
Not sure if this helps: https://github.com/BurntSushi/toml-test/blob/master/tests/valid/comments-everywhere.toml
Hmm, I think it is edited manually, not generated by toml.Encode
.
Hmm, I think it is edited manually, not generated by toml.Encode.
I see. I'm fine not adding this (commented toml files) in for 0.1.0.
The library doesn't have support for it yet in the encoder. See the open issues / pulls there.
I'm fine not adding this (commented toml files) in for 0.1.0
Yup, let's skip it for now.
Then should we merge this now (along with #145)?
Then should we merge this now (along with #145)?
LGTM, but I'm losing faith in myself.